Infer from annotated parameters of context sensitive functions in the first inference pass by Andarist · Pull Request #56460 · microsoft/TypeScript

Andarist · 2023-11-19T10:27:23Z

fixes #56459
fixes #60047
fixes #60648

… first inference pass

…tated-params-of-context-sensitive-functions

Andarist · 2024-09-24T16:57:01Z

@jakebailey could you run the extended test suite here? :)

jakebailey · 2024-09-24T17:08:51Z

@typescript-bot test it

typescript-bot · 2024-09-24T17:08:56Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-09-24T17:32:22Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-09-24T17:35:43Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/56460/merge:

Everything looks good!

typescript-bot · 2024-09-24T17:48:59Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,378	_50,378	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,997k (± 0.90%)}	_{195,147k (± 0.90%)}	_~	_192,687k	_196,341k	_{p=0.298 n=6}
_{Parse Time}	_{1.57s (± 1.19%)}	_{1.57s (± 0.40%)}	_~	_1.56s	_1.58s	_{p=0.677 n=6}
_{Bind Time}	_{0.86s (± 0.60%)}	_{0.86s (± 1.20%)}	_~	_0.85s	_0.87s	_{p=0.204 n=6}
_{Check Time}	_{11.38s (± 0.28%)}	_{11.35s (± 0.38%)}	_~	_11.28s	_11.40s	_{p=0.414 n=6}
_{Emit Time}	_{3.24s (± 1.09%)}	_{3.25s (± 0.81%)}	_~	_3.21s	_3.28s	_{p=0.747 n=6}
_{Total Time}	_{17.05s (± 0.33%)}	_{17.04s (± 0.15%)}	_~	_17.00s	_17.08s	_{p=1.000 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,102	_947,104	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_410,738	_410,744	_{+6 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,224,025k (± 0.00%)}	_{1,223,983k (± 0.00%)}	_~	_1,223,925k	_1,224,065k	_{p=0.128 n=6}
_{Parse Time}	_{6.60s (± 0.54%)}	_{6.59s (± 0.78%)}	_~	_6.54s	_6.67s	_{p=0.422 n=6}
_{Bind Time}	_{1.87s (± 0.22%)}	_1.87s	_~	_~	_~	_{p=0.405 n=6}
_{Check Time}	_{31.28s (± 0.31%)}	_{31.34s (± 0.12%)}	_~	_31.29s	_31.38s	_{p=0.376 n=6}
_{Emit Time}	_{15.07s (± 0.76%)}	_{15.04s (± 0.44%)}	_~	_14.95s	_15.12s	_{p=0.748 n=6}
_{Total Time}	_{54.82s (± 0.25%)}	_{54.83s (± 0.14%)}	_~	_54.72s	_54.91s	_{p=1.000 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,521,651	_2,521,572	_{-79 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_936,037	_936,022	_{-15 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,351,741k (± 0.00%)}	_{2,351,774k (± 0.00%)}	_~	_2,351,703k	_2,351,859k	_{p=0.298 n=6}
_{Parse Time}	_{9.29s (± 0.24%)}	_{9.28s (± 0.33%)}	_~	_9.24s	_9.32s	_{p=0.518 n=6}
_{Bind Time}	_{2.14s (± 0.42%)}	_{2.14s (± 0.35%)}	_~	_2.13s	_2.15s	_{p=0.798 n=6}
_{Check Time}	_{73.38s (± 0.66%)}	_{73.55s (± 0.41%)}	_~	_73.02s	_73.79s	_{p=0.378 n=6}
_{Emit Time}	_{0.28s (± 2.70%)}	_{0.27s (± 2.77%)}	_~	_0.26s	_0.28s	_{p=0.195 n=6}
_{Total Time}	_{85.09s (± 0.57%)}	_{85.24s (± 0.38%)}	_~	_84.68s	_85.51s	_{p=0.470 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,249,990	_1,249,995	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,937	_264,936	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,403,943k (± 0.04%)}	_{2,404,184k (± 0.04%)}	_~	_2,403,094k	_2,405,323k	_{p=0.936 n=6}
_{Parse Time}	_{5.14s (± 0.87%)}	_{5.10s (± 0.95%)}	_~	_5.05s	_5.18s	_{p=0.126 n=6}
_{Bind Time}	_{1.90s (± 0.72%)}	_{1.90s (± 0.43%)}	_~	_1.89s	_1.91s	_{p=0.933 n=6}
_{Check Time}	_{34.90s (± 0.46%)}	_{35.00s (± 0.43%)}	_~	_34.90s	_35.30s	_{p=0.126 n=6}
_{Emit Time}	_{3.06s (± 5.00%)}	_{3.05s (± 4.75%)}	_~	_2.93s	_3.26s	_{p=0.809 n=6}
_{Total Time}	_{45.02s (± 0.52%)}	_{45.08s (± 0.40%)}	_~	_44.85s	_45.33s	_{p=0.810 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,249,990	_1,249,995	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,937	_264,936	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,479,239k (± 0.02%)}	_{2,478,244k (± 0.01%)}	_{-996k (- 0.04%)}	_2,477,876k	_2,478,497k	_{p=0.031 n=6}
_{Parse Time}	_{5.29s (± 0.80%)}	_{5.30s (± 0.97%)}	_~	_5.23s	_5.36s	_{p=0.748 n=6}
_{Bind Time}	_{1.72s (± 0.48%)}	_{1.72s (± 0.57%)}	_~	_1.71s	_1.73s	_{p=0.862 n=6}
_{Check Time}	_{35.22s (± 0.35%)}	_{35.34s (± 0.72%)}	_~	_35.06s	_35.78s	_{p=0.423 n=6}
_{Emit Time}	_{3.03s (± 5.73%)}	_{3.00s (± 0.69%)}	_~	_2.98s	_3.03s	_{p=0.520 n=6}
_{Total Time}	_{45.28s (± 0.40%)}	_{45.38s (± 0.63%)}	_~	_45.12s	_45.85s	_{p=0.689 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_260,917	_260,916	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,357	_106,356	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{436,535k (± 0.04%)}	_{436,686k (± 0.04%)}	_~	_436,450k	_436,905k	_{p=0.173 n=6}
_{Parse Time}	_{3.45s (± 0.89%)}	_{3.46s (± 1.17%)}	_~	_3.40s	_3.51s	_{p=0.936 n=6}
_{Bind Time}	_{1.31s (± 0.39%)}	_{1.31s (± 0.57%)}	_~	_1.30s	_1.32s	_{p=0.784 n=6}
_{Check Time}	_{18.15s (± 0.34%)}	_{18.14s (± 0.29%)}	_~	_18.08s	_18.21s	_{p=0.810 n=6}
_{Emit Time}	_{1.53s (± 2.08%)}	_{1.52s (± 1.64%)}	_~	_1.49s	_1.56s	_{p=0.872 n=6}
_{Total Time}	_{24.44s (± 0.26%)}	_{24.43s (± 0.26%)}	_~	_24.32s	_24.50s	_{p=1.000 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,916	_225,916	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,414	_94,414	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,896k (± 0.03%)}	_{370,975k (± 0.03%)}	_~	_370,800k	_371,119k	_{p=0.298 n=6}
_{Parse Time}	_{2.76s (± 0.42%)}	_{2.74s (± 1.15%)}	_~	_2.70s	_2.78s	_{p=0.369 n=6}
_{Bind Time}	_{1.57s (± 1.90%)}	_{1.57s (± 0.87%)}	_~	_1.56s	_1.59s	_{p=0.935 n=6}
_{Check Time}	_{15.83s (± 0.34%)}	_{15.84s (± 0.30%)}	_~	_15.79s	_15.90s	_{p=0.747 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.16s (± 0.39%)}	_{20.15s (± 0.36%)}	_~	_20.06s	_20.24s	_{p=1.000 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,099,008	_3,098,997	_{-11 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,068,764	_1,068,755	_{-9 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,196,196k (± 0.01%)}	_{3,196,336k (± 0.00%)}	_~	_3,196,260k	_3,196,367k	_{p=0.810 n=6}
_{Parse Time}	_{13.88s (± 0.40%)}	_{13.88s (± 0.49%)}	_~	_13.80s	_13.97s	_{p=0.873 n=6}
_{Bind Time}	_{4.33s (± 0.25%)}	_{4.33s (± 0.62%)}	_~	_4.30s	_4.37s	_{p=1.000 n=6}
_{Check Time}	_{81.57s (± 0.39%)}	_{81.71s (± 0.30%)}	_~	_81.38s	_81.98s	_{p=0.297 n=6}
_{Emit Time}	_{22.40s (± 1.72%)}	_{22.26s (± 0.29%)}	_~	_22.18s	_22.37s	_{p=0.575 n=6}
_{Total Time}	_{122.17s (± 0.37%)}	_{122.18s (± 0.20%)}	_~	_121.87s	_122.47s	_{p=1.000 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_278,920	_278,921	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_113,837	_113,837	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{428,440k (± 0.02%)}	_{428,437k (± 0.02%)}	_~	_428,319k	_428,509k	_{p=1.000 n=6}
_{Parse Time}	_{4.89s (± 0.44%)}	_{4.89s (± 0.46%)}	_~	_4.86s	_4.92s	_{p=0.935 n=6}
_{Bind Time}	_{2.12s (± 0.75%)}	_{2.13s (± 0.77%)}	_~	_2.11s	_2.15s	_{p=0.616 n=6}
_{Check Time}	_{21.87s (± 0.42%)}	_{21.96s (± 0.63%)}	_~	_21.71s	_22.11s	_{p=0.199 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.88s (± 0.34%)}	_{28.98s (± 0.57%)}	_~	_28.68s	_29.15s	_{p=0.229 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_540,027	_540,075	_{+48 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_181,292	_181,342	_{+50 (+ 0.03%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{483,516k (± 0.01%)}	_{483,534k (± 0.01%)}	_~	_483,463k	_483,624k	_{p=0.810 n=6}
_{Parse Time}	_{4.01s (± 0.26%)}	_{4.02s (± 0.47%)}	_~	_3.99s	_4.04s	_{p=1.000 n=6}
_{Bind Time}	_{1.42s (± 0.57%)}	_{1.43s (± 0.85%)}	_~	_1.41s	_1.44s	_{p=0.677 n=6}
_{Check Time}	_{22.86s (± 0.22%)}	_{22.84s (± 0.28%)}	_~	_22.76s	_22.94s	_{p=0.629 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.29s (± 0.21%)}	_{28.28s (± 0.19%)}	_~	_28.22s	_28.34s	_{p=0.746 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-09-24T18:45:18Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/56460/merge:

Everything looks good!

jakebailey · 2024-09-25T20:26:48Z

@typescript-bot pack this

typescript-bot · 2024-09-25T20:26:52Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started	✅ Results

typescript-bot · 2024-09-25T20:28:46Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/163721/artifacts?artifactName=tgz&fileId=38CAD1B2C67CA2FCC8B4A76C2D66BE653CFF98531EB9AA4C10F06CC22114767B02&fileName=/typescript-5.7.0-insiders.20240925.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.7.0-pr-56460-9".;

jakebailey · 2024-09-25T21:17:59Z

src/compiler/checker.ts

+            if (checkMode & CheckMode.Inferential) {
+                const contextualSignature = getContextualSignature(node);
+                if (contextualSignature) {
+                    inferFromAnnotatedParameters(node, contextualSignature, getInferenceContext(node)!);
+                }
+            }


Is it not a little weird for getInferenceContext and inferFromAnnotatedParameters to get called here? I'm not finding other examples where we're doing this sort of thing outside of a function intended to contextually check (which this function is not, contextuallyCheckFunctionExpressionOrObjectLiteralMethod is).

hm, this might be the first time this is called like it but the placement of those calls here is what fixes the bug conceptually - as in, for the added test cases it's important to infer before contextually checking those functions

Contextual check of functions can fix "requested" inference type parameters and that creates an ordering issue for #56459 as the parameter type "request" can happen before inferFromAnnotatedParameters even has a chance to be called on the other function that comes later in the source code.

And the similar problem happens when it comes to #60047 . The conditional type asks for the inferred type of the type parameter and since by that time the inferFromAnnotatedParameters was not called it resolves to its constraint. Then the arguments fail to be typechecked against current parameter types in getSignatureApplicabilityError so the algorithm returns, never reaching the second inference pass that starts to include context-sensitive parameters.

So if those issues are meant to be fixed it's absolutely necessary to call inferFromAnnotatedParameters within the first inference pass and that doesn't check context-sensitive functions, that's deferred to the second inference pass. I don't see how to even attempt to fix this in any other way given the known limitations around context-sensitive expressions and their associated implementation details

…tated-params-of-context-sensitive-functions

jakebailey · 2025-02-21T23:28:54Z

I feel like this may have had some overlap with #60964; would be interested in a rebase of this PR.

Andarist · 2025-02-22T08:33:01Z

@jakebailey synced with main

…tated-params-of-context-sensitive-functions

Infer from annotated parameters of context sensitive functions in the…

cc49efd

… first inference pass

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 19, 2023

sandersn requested review from ahejlsberg and weswigham November 29, 2023 17:59

typescript-bot removed the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 29, 2023

sandersn assigned ahejlsberg Nov 29, 2023

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Nov 29, 2023

Andarist added 4 commits March 15, 2024 11:13

Merge remote-tracking branch 'origin/main' into infer-early-from-anno…

1655479

…tated-params-of-context-sensitive-functions

Merge remote-tracking branch 'origin/main' into infer-early-from-anno…

8cf8770

…tated-params-of-context-sensitive-functions

Merge remote-tracking branch 'origin/main' into infer-early-from-anno…

7d2278d

…tated-params-of-context-sensitive-functions

add extra tests

ac20ac6

Andarist mentioned this pull request Sep 24, 2024

Function expression or method is not inferable when we have mapped type with a conditional type #60047

Open

jakebailey reviewed Sep 25, 2024

View reviewed changes

Andarist added 2 commits December 1, 2024 21:59

Merge remote-tracking branch 'origin/main' into infer-early-from-anno…

1334a37

…tated-params-of-context-sensitive-functions

add extra completion test

e34897d

Andarist mentioned this pull request Dec 2, 2024

Generic function with function as argument autocomplete broken, unless generic argument of the argument function is it's first argument #60648

Open

jakebailey mentioned this pull request Feb 21, 2025

Infer from annotated return type nodes before assigning contextual parameter types #60964

Merged

Merge remote-tracking branch 'origin/main' into infer-early-from-anno…

6bee359

…tated-params-of-context-sensitive-functions

Andarist force-pushed the infer-early-from-annotated-params-of-context-sensitive-functions branch from 7c98b34 to 6bee359 Compare February 22, 2025 08:41

Merge remote-tracking branch 'origin/main' into infer-early-from-anno…

e20c997

…tated-params-of-context-sensitive-functions

Conversation

Andarist commented Nov 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Andarist commented Sep 24, 2024

Uh oh!

jakebailey commented Sep 24, 2024

Uh oh!

typescript-bot commented Sep 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 24, 2024

Uh oh!

typescript-bot commented Sep 24, 2024

Uh oh!

typescript-bot commented Sep 24, 2024

tsc

Uh oh!

typescript-bot commented Sep 24, 2024

Uh oh!

jakebailey commented Sep 25, 2024

Uh oh!

typescript-bot commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakebailey Sep 25, 2024

Choose a reason for hiding this comment

Uh oh!

Andarist Sep 25, 2024

Choose a reason for hiding this comment

Uh oh!

jakebailey commented Feb 21, 2025

Uh oh!

Andarist commented Feb 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Andarist commented Nov 19, 2023 •

edited

Loading

typescript-bot commented Sep 24, 2024 •

edited

Loading

typescript-bot commented Sep 25, 2024 •

edited

Loading

typescript-bot commented Sep 25, 2024 •

edited

Loading